Repository navigation
GABA AssetsController integration - #131
Conversation
|
since MetaMask/core#18 landed, this needs to have the updated GABA version to be good to go. |
brunobar79
left a comment
There was a problem hiding this comment.
Good stuff 👍!
Just a few minor comments here. I'll defer to @bitpshr the decision of if / when / how to merge because of the GABA blockers
| } = this.props; | ||
|
|
||
| return ( | ||
| <View style={styles.wrapper} testID={'add-asset-screen'}> |
There was a problem hiding this comment.
I'd call params something more descriptive and also change the testID to add-${assetType}-screen
| /> | ||
| </ScrollableTabView> | ||
| ) : ( | ||
| <AddCustomCollectible navigation={navigation} testID={'add-cutom-collectible'} /> |
There was a problem hiding this comment.
Typo: "add-custom-collectible"
| <Image source={{ uri: asset.logo }} style={styles.itemLogo} /> | ||
| <TouchableOpacity style={styles.itemWrapper} key={`asset-${asset.tokenId}`}> | ||
| <View style={styles.imageWrapper}> | ||
| {asset.image ? ( |
There was a problem hiding this comment.
Would be nice to move this logic into a CollectibleImage component.
|
@bitpshr @brunobar79 from this comment I decomposed the tokens and collectibles list into assets element and assets image components, let me know what you think. |
|
@estebanmino Looks much better. Thanks! BTW, looks like you need to pass assetType in the tests of this component: MetaMask/website@5145f83#diff-d0a7b42290800dcd24c96726b89b4b80R11 |
|
DIdn't notice it, thanks. I'll merge it when tests are ready! |
* Wallet tokens from AssetsController * Update some snapshots failing * wallet collectibles support * update GABA version * update tests on AssetsController * Assets components decomposition * AddAsset add assetType to snapshot test
Description
This PR adds support for collectibles, according to
AssetsControlleron GABA.UPDATE: After MetaMask/core#18 branch update, assets per account and network.
Checklist
Issue
Resolves #???
BLOCKER: eth-contract-metadata is not the official, we should decide what to do with collectibles metadata before merge.
Related MetaMask/core#18